Allow Blacklight::Solr::Repository#search to be called with no args #3758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be in Blacklight 8, with params using a default value of `{}`, it's convenient, and preferable to keep this backwards compat when no reason not to.
jrochkind
force-pushed
the
solr_repository_no_args
branch
from
5a2c19d to
0c3b09a
Compare
seanaery
approved these changes
Oct 28, 2025
jrochkind
added a commit
to sciencehistory/scihist_digicoll
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be in Blacklight 8, with params using a default value of
{}, it's convenient, and preferable to keep this backwards compat when no reason not to.