Skip to content

Remove comments that imply Bootstrap 4 is still supported in BL9 (it … #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

Remove comments that imply Bootstrap 4 is still supported in BL9 (it … #3776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/javascript/blacklight-frontend/checkbox_submit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
attribute (HTML5-style doc-*) that contains the id/primary key
of the object in question -- used by plugin for a unique value for
DOM id's.
Uses HTML for a checkbox compatible with Bootstrap 4.
Uses HTML for a checkbox compatible with Bootstrap.
new CheckboxSubmit(document.querySelector('form.something')).render()
*/
export default class CheckboxSubmit {
Expand All @@ -36,7 +36,7 @@ export default class CheckboxSubmit {
}).then((json) => {
this.labelTarget.removeAttribute('disabled')
this.checkboxTarget.removeAttribute('disabled')
// For accessibility return keyboard focus
// For accessibility return keyboard focus
// back to the checkbox after form submission
this.checkboxTarget.focus()
this.updateStateFor(!this.checked)
Expand Down
1 change: 0 additions & 1 deletion lib/blacklight/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ def initialized_default_configuration?
property :header_component, default: Blacklight::HeaderComponent
property :full_width_layout, default: false

# bootstrap_version may be set to 4 or 5
bootstrap_version = ENV['BOOTSTRAP_VERSION'].presence || "5"
property :bootstrap_version, default: /(\d)(?:\.\d){0,2}/.match(bootstrap_version)[1].to_i

Expand Down
2 changes: 1 addition & 1 deletion lib/generators/blacklight/templates/catalog_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class <%= controller_name.classify %>Controller < ApplicationController
# rescue_from Blacklight::Exceptions::InvalidRequest, with: :my_handling_method
configure_blacklight do |config|
## Specify the style of markup to be generated (may be 4 or 5)
## Specify the style of markup to be generated
# config.bootstrap_version = 5
#
## Class for sending and receiving requests from a search index
Expand Down