Rescue Parslet parsing errors on advanced search … #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and raise Blacklight's InvalidRequest error. This currently happens when processing queries in for advanced search features in the single-search-box/q param, but not for advanced search itself. This will cause the error if only one field has a parsing error, but probably a good idea to indicate that to the user and allow them to hit the back button and fix their search (as opposed to getting a generic rails error page).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and raise Blacklight's InvalidRequest error.
This currently happens when processing queries in for advanced search features in the single-search-box/q param, but not for advanced search itself.
This will cause the error if only one field has a parsing error, but probably a good idea to indicate that to the user and allow them to hit the back button and fix their search (as opposed to getting a generic rails error page).