Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use modern ViewComponent slot syntax as Blacklight #239

Closed
wants to merge 1 commit into from
Closed

use modern ViewComponent slot syntax as Blacklight #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/components/blacklight_range_limit/range_facet_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<%= render(@layout.new(facet_field: @facet_field)) do |component| %>
<% component.label do %>
<% component.with_label do %>
<%= @facet_field.label %>
<% end %>

<% component.body do %>
<% component.with_body do %>
<div class="limit_content range_limit <%= @facet_field.key %>-config blrl-plot-config">
<% if @facet_field.selected_range_facet_item %>
<%= render BlacklightRangeLimit::RangeSegmentsComponent.new(facet_field: @facet_field, facet_items: [@facet_field.selected_range_facet_item], classes: ['current']) %>
Expand Down Expand Up @@ -37,7 +37,7 @@

<%= render BlacklightRangeLimit::RangeFormComponent.new(facet_field: @facet_field, classes: @classes) %>

<%= more_link(key: @facet_field.key, label: @facet_field.label) unless @facet_field.in_modal? %>
<%= with_more_link(key: @facet_field.key, label: @facet_field.label) unless @facet_field.in_modal? %>

<% if @facet_field.missing_facet_item && !request.xhr? %>
<%= render BlacklightRangeLimit::RangeSegmentsComponent.new(facet_field: @facet_field, facet_items: [@facet_field.missing_facet_item], classes: ['missing', 'subsection']) %>
Expand Down
1 change: 0 additions & 1 deletion spec/components/range_facet_component_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
instance_double(
BlacklightRangeLimit::FacetFieldPresenter,
key: 'key',
html_id: 'id',
active?: false,
collapsed?: false,
in_modal?: false,
Expand Down
1 change: 0 additions & 1 deletion spec/components/range_form_component_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
instance_double(
BlacklightRangeLimit::FacetFieldPresenter,
key: 'key',
html_id: 'id',
active?: false,
collapsed?: false,
in_modal?: false,
Expand Down
Loading