Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display properly when there is no data #276

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Display properly when there is no data #276

merged 2 commits into from
Nov 12, 2024

Conversation

jrochkind
Copy link
Member

  • keep chart wrapper with explicit aspect-ratio from taking up space when there is no chart
  • avoid JS error when there is no data available

Before

Screenshot 2024-11-12 at 12 25 05 PM

Plus a JS error.

After

Screenshot 2024-11-12 at 12 29 34 PM

With no JS error.

@seanaery
Copy link
Collaborator

That's a nice change. It also makes #237 not stand out so much.

@seanaery seanaery merged commit 8136d03 into main Nov 12, 2024
9 checks passed
@seanaery seanaery deleted the empty_data branch November 12, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrochkind @seanaery