Support open-ended ranges #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrochkind
force-pushed
the
one_ended_ranges
branch
from
94493e3
to
6d65f56
Compare
seanaery
reviewed
Nov 13, 2024
seanaery
reviewed
Nov 13, 2024
jrochkind
force-pushed
the
one_ended_ranges
branch
from
6d65f56
to
65989bb
Compare
seanaery
approved these changes
Nov 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
Relies on behavior that will be in upcoming Blacklight release from projectblacklight/blacklight#3443 -- but polyfills this behavior in, kind of hackily. (It would have been even hackier to try to keep things no-op on old Blacklights without the fix I think!). Assume BL fix will be in next BL 8.x release, since it's already merged.
Include some new browser specs meant to try to prevent regression, as this was a breakage tests didn't fix caused by a major refactor previous.
I started work on this before noticing @taylor-steve's #258, but once I did notice reivewed his code and saw a couple things I had missed actuallyand ideas for improving mine, and borrowed his tests. Thanks @taylor-steve !