old Rails require old concurrent-ruby when running in CI #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird that that didn't do it. |
|
Hm. It may actually not be possible to workaround. The error happens during the engine cart build phase. Not sure why we can't control what version fo concurrent-ruby is available there by Gemfile though. Havne't quite given up yet. |
jrochkind
force-pushed
the
test_old_rails
branch
from
63b3ba3 to
2b88544
Compare
|
engine cart man, gahh. |
|
OK maybe we do just have to stop testing EOL rails. sorry for those still on it. |
|
A valiant effort trying to work around it - thanks for looking into it @jrochkind |
|
Yeah I literally cant figure out any way to make it work with the dreaded engine_cart at all, so far. Not even undesirable ways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized problem in #313