Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old Rails require old concurrent-ruby when running in CI #314

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jrochkind
Copy link
Member

Realized problem in #313

@jrochkind
Copy link
Member Author

Weird that that didn't do it.

@jrochkind jrochkind marked this pull request as draft February 11, 2025 19:55
@jrochkind
Copy link
Member Author

Hm. It may actually not be possible to workaround.

The error happens during the engine cart build phase. Not sure why we can't control what version fo concurrent-ruby is available there by Gemfile though. Havne't quite given up yet.

@jrochkind
Copy link
Member Author

engine cart man, gahh.

@jrochkind
Copy link
Member Author

OK maybe we do just have to stop testing EOL rails. sorry for those still on it.

@seanaery
Copy link
Collaborator

A valiant effort trying to work around it - thanks for looking into it @jrochkind

@jrochkind
Copy link
Member Author

Yeah I literally cant figure out any way to make it work with the dreaded engine_cart at all, so far. Not even undesirable ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants