OpenStack: Don't modify port dict when collecting additional information #10192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on projectcalico#10160 I noticed that our UT code sometimes has to reset generated elements in the mock port dicts that it uses, e.g. del self.osdb_ports[0]['network_qos_policy_id'] This is because our driver code gets a port dict, in a create or update hook, and then has to gather various pieces of related information, from other tables in the Neutron DB, before being ready to map that to a corresponding Calico WorkloadEndpoint; and it stores that additional information by adding keys to the supplied port dict. It's a bit fragile to modify the input port dict like that, and it would be better to collect the additional information in a separate object, as this change now does.
marvin-tigera
added
release-note-required
nelljerram
added
docs-not-required
marvin-tigera
added
release-note-required
nelljerram
added
docs-not-required
fasaxc
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #10160 I noticed that our UT code sometimes has to reset generated elements in the mock port dicts that it uses, e.g.
This is because our driver code gets a port dict, in a create or update hook, and then has to gather various pieces of related information, from other tables in the Neutron DB, before being ready to map that to a corresponding Calico WorkloadEndpoint; and it stores that additional information by adding keys to the supplied port dict.
It's a bit fragile to modify the input port dict like that, and it would be better to collect the additional information in a separate object, as this change now does.