-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Switch to n4-highpcu-4 instances for Felix FVs #11578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR optimizes CI costs by switching Felix FV test execution from n4-standard-4 to n4-highcpu-4 GCP instance types, based on observed low RAM usage patterns in the test runners.
- Introduces VM_MACHINE_TYPE environment variable for configurable instance types
- Adds documentation explaining the choice of 4 vCPUs and high-CPU machine type
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| felix/.semaphore/fv-prologue | Exports VM_MACHINE_TYPE=n4-highcpu-4 with explanatory comments about vCPU requirements and RAM usage patterns |
| .semaphore/vms/create-test-vms | Updates gcloud instance creation to use configurable machine_type variable with n4-standard-4 as default for backward compatibility |
|
Wow, I hit OOMs with this. One or two tests use lots of RAM, not sure why (perhaps gratuitous logging to a memory buffer?) |
|
Looks like the QoS tests slurp up 4GB of BPF logs when they run at debug 🤔 |
Each batch is now quite small so we can use low-RAM instance types.
9452259 to
91cfdcd
Compare
|
QoS tests have been tweaked under #11593. Let's give this another shot... |
Option was being applied to a temporary object and not copied over. Default to a max of 64MiB.
Description
Stats report consistently low RAM usage on the test runners, so this should save some cost.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.