eBPF: fix that local workload with borrowed IPs lose connectivity #11640
+78
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasaxc
added
release-note-required
fasaxc
force-pushed
the
fix-borrowed-local-wl-route
branch
2 times, most recently
from
ef1074c to
4365382
Compare
fasaxc
force-pushed
the
fix-borrowed-local-wl-route
branch
from
4365382 to
84f1a27
Compare
Fails due to bug.
The old condition checked that the "borrowed" flag was false before checking if the route was a workload. There's no reason that a local workload can't have a borrowed IP, so this was a bug. We now have an explicit "really a local WEP" flag; use that explicitly to avoid confusion with the informational flags (where multiple flags can be set for borrowed IPs).
fasaxc
force-pushed
the
fix-borrowed-local-wl-route
branch
from
84f1a27 to
6afa792
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where local workloads with borrowed IPs would lose connectivity in eBPF mode. The issue was that the old code incorrectly excluded routes for local workloads if they had borrowed IPs. The fix introduces an explicit LocalWorkload flag to distinguish actual workload endpoints from IPAM blocks, avoiding confusion with the informational Borrowed flag.
Changes:
- Refactored route classification logic to use explicit
LocalWorkloadflag instead of checking multiple conditions - Added comprehensive test coverage for borrowed workload IPs scenario
- Improved code clarity with better comments explaining the borrowed IP handling
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| felix/calc/l3_route_resolver.go | Sets LocalWorkload flag explicitly for local workload endpoints to disambiguate from IPAM blocks |
| felix/dataplane/linux/bpf_route_mgr.go | Refactored route handling to check GetLocalWorkload() first, then handle IPAM blocks separately |
| felix/fv/routing_test.go | Added new test case for borrowed workload IPs and refactored description strings; contains a bug on line 889 |
| felix/routetable/routeclass_string.go | Auto-generated code update from stringer tool |
caseydavenport
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old condition checked that the "borrowed" flag was false before checking if the route was a workload. There's no reason that a local workload can't have a borrowed IP, so this was a bug.
We now have an explicit "really a local WEP" flag; use that explicitly to avoid confusion with the informational flags (where multiple flags can be set for borrowed IPs).
Related issues/PRs
CORE-12198
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.