Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation: External Processing support #5867

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

izturn
Copy link
Member

@izturn izturn commented Oct 19, 2023

Signed-off-by: Gang Liu [email protected]

Implementation proposal to address #5123

@izturn izturn requested a review from a team as a code owner October 19, 2023 03:44
@izturn izturn requested review from skriss and sunjayBhatia and removed request for a team October 19, 2023 03:44
@izturn izturn self-assigned this Oct 19, 2023
@izturn izturn added area/infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note/infra An infrastructure update for the release notes. labels Oct 19, 2023
@izturn
Copy link
Member Author

izturn commented Oct 19, 2023

Due to the current proposal status, relevant unit tests have not been added yet

Signed-off-by: gang.liu <[email protected]>
@izturn izturn added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: Patch coverage is 17.76316% with 250 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5b0d091). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/dag/httpproxy_processor.go 28.98% 87 Missing and 11 partials ⚠️
internal/envoy/v3/listener.go 6.89% 54 Missing ⚠️
internal/envoy/v3/route.go 0.00% 42 Missing and 1 partial ⚠️
cmd/contour/serve.go 4.76% 20 Missing ⚠️
cmd/contour/servecontext.go 9.09% 19 Missing and 1 partial ⚠️
internal/xdscache/v3/listener.go 38.88% 11 Missing ⚠️
internal/fixture/httpproxy.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5867   +/-   ##
=======================================
  Coverage        ?   80.06%           
=======================================
  Files           ?      133           
  Lines           ?    20279           
  Branches        ?        0           
=======================================
  Hits            ?    16237           
  Misses          ?     3736           
  Partials        ?      306           
Files with missing lines Coverage Δ
internal/dag/dag.go 98.78% <ø> (ø)
internal/sorter/sorter.go 100.00% <ø> (ø)
pkg/config/parameters.go 88.05% <ø> (ø)
internal/fixture/httpproxy.go 86.27% <0.00%> (ø)
internal/xdscache/v3/listener.go 89.47% <38.88%> (ø)
cmd/contour/serve.go 21.36% <4.76%> (ø)
cmd/contour/servecontext.go 81.01% <9.09%> (ø)
internal/envoy/v3/route.go 76.56% <0.00%> (ø)
internal/envoy/v3/listener.go 91.13% <6.89%> (ø)
internal/dag/httpproxy_processor.go 85.40% <28.98%> (ø)

Copy link

github-actions bot commented Nov 3, 2023

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2023
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2024
@izturn izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2024
@wilsonwu
Copy link
Member

wilsonwu commented Aug 1, 2024

Let's review this PR again, this feature already ran on our product for 2 months, it is stable, we'd like to comtribute to community.

Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2024
@izturn izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 23, 2024
Copy link

github-actions bot commented Sep 9, 2024

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 9, 2024
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2024
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 21, 2024
@lorem-dev
Copy link

Anyone, please review it 🙏 🙏 🙏

@Hozeri
Copy link

Hozeri commented Nov 1, 2024

Please review it

internal/dag/dag.go Outdated Show resolved Hide resolved
@lorem-dev
Copy link

@izturn, could you please squash the commits with linting fixes and format the commit messages as well?

@izturn
Copy link
Member Author

izturn commented Nov 1, 2024

@izturn, could you please squash the commits with linting fixes and format the commit messages as well?

ok, i will update it later

@izturn izturn added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Nov 4, 2024
@izturn izturn removed the release-note/infra An infrastructure update for the release notes. label Nov 4, 2024
@izturn
Copy link
Member Author

izturn commented Nov 4, 2024

@izturn, could you please squash the commits with linting fixes and format the commit messages as well?

done

@donatgorbachev
Copy link

@skriss, could you please review this PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra kind/feature Categorizes issue or PR as related to a new feature. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants