add comma separated support for -l option #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughAdds comma-separated input support for the -l/--list flag, centralizes hosts input parsing via preProcessArgument, and tightens stdin/stream-mode validation (stdin exclusivity across input flags; disallow hosts in stream mode). Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant CLI as CLI Options
participant Runner
participant ArgProc as preProcessArgument
User->>CLI: Provide -l/--list (file | stdin | comma-separated)
CLI->>CLI: Validate stdin exclusivity across flags
CLI-->>User: Error if multiple flags use stdin
CLI->>CLI: If stream mode, disallow hosts
CLI-->>User: Error if hosts in stream mode
User->>Runner: Run with validated options
Runner->>ArgProc: Resolve hosts input
ArgProc-->>Runner: []hosts or error
Runner-->>User: Proceed or report error
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
internal/runner/options.go (1)
286-295: Remove stream-mode check from the multi-stdin exclusivity block.The inner
if options.Stream { ... "argument stdin not supported in stream mode" }only triggers when two flags use stdin and is redundant/confusing since stream-mode constraints are enforced below. Keep this block focused on exclusivity across flags.Apply this diff:
- // stdin can be set only on one flag - if (argumentHasStdin(options.Domains) && argumentHasStdin(options.WordList)) || - (argumentHasStdin(options.Domains) && argumentHasStdin(options.Hosts)) || - (argumentHasStdin(options.WordList) && argumentHasStdin(options.Hosts)) { - if options.Stream { - gologger.Fatal().Msgf("argument stdin not supported in stream mode") - } - gologger.Fatal().Msgf("stdin can be set for one flag") - } + // stdin can be set only on one flag + if (argumentHasStdin(options.Domains) && argumentHasStdin(options.WordList)) || + (argumentHasStdin(options.Domains) && argumentHasStdin(options.Hosts)) || + (argumentHasStdin(options.WordList) && argumentHasStdin(options.Hosts)) { + gologger.Fatal().Msgf("stdin can be set for one flag") + }
🧹 Nitpick comments (2)
internal/runner/options.go (1)
303-305: Clarify the stream-mode error for -l with a usage hint.Suggest making the message actionable so users know how to feed stdin in stream mode.
- gologger.Fatal().Msgf("hosts not supported in stream mode") + gologger.Fatal().Msgf("hosts (-l) not supported in stream mode; pipe input instead (e.g., dnsx -stream < hosts.txt)")internal/runner/runner.go (1)
256-259: Add empty-item guard and clearer empty-input error
- In the
if sc == nilblock, distinguishHosts == ""and return
errors.New("no input provided: use -l <file|comma-separated values> or pipe via stdin")instead of the opaque"empty argument".- In the host loop, immediately skip blank entries after trimming:
for item := range sc { item := normalize(item) if item == "" { continue } … }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
internal/runner/options.go(3 hunks)internal/runner/runner.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze (go)
- GitHub Check: Functional Test (windows-latest)
🔇 Additional comments (1)
internal/runner/options.go (1)
97-97: Help text update for -l looks good.Accurately reflects comma-separated support and aligns with -d/-w descriptions.
Mzack9999
requested changes
Aug 29, 2025
| } | ||
| } else { | ||
| return errors.New("hosts file or stdin not provided") | ||
| sc, err = r.preProcessArgument(r.options.Hosts) |
Member
There was a problem hiding this comment.
This seems to break stdin support:
% echo scanme.sh | go run . -verbose
_ __ __
__| | _ __ ___ \ \/ /
/ _' || '_ \ / __| \ /
| (_| || | | |\__ \ / \
\__,_||_| |_||___//_/\_\
projectdiscovery.io
[INF] Current dnsx version 1.2.2 (latest)
%
Mzack9999
requested changes
Oct 8, 2025
Member
Mzack9999
left a comment
Mzack9999
left a comment
There was a problem hiding this comment.
breaks stdin import + failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #878
Summary by CodeRabbit