-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to use ICU4X #335
base: main
Are you sure you want to change the base?
Switch to use ICU4X #335
Conversation
9eb4897
to
0c56e64
Compare
No performance impact from the switch on any of the |
@dminor @aethanyc @makotokato - I'd like to ask for your architectural advice. Historically, fluent-bundle was using We will also want to add DateTimeFormat and NumberFormat, and all three are transitive. They are created based on My understanding is that for Mozilla use case, you'd prefer to create each component instance using custom If so, this will require also changes to `L10nRegistry as this is where FluentBundle is generated. |
I have a pile of pending PRs here in this repo, one of which, #332, fixes the CI failure that you see here. |
I'm going to rebase this on main to resolve the merge conflicts so it's that much easier to work on and build on. That way if somebody branches from this to keep working on it it should be able to integrate once things start coming together. In the process I'm running If by chance you have newer work on this branch than what is pushed here do feel free to force push and clobber my rebase. I can always redo it, but it would likely be easier to redo from scratch with my |
@zbraniecki One thing I noticed during the rebase is that the refactoring of |
It looks like I goofed up some of the workspace related changes a little in the rebase, straightening that out now. |
BREAKING CHANGE: This changes the type used for language ids from icu_locid::LanguageIdentifier to icu_locid:LanguageIdentifier.
Fixes #329