Skip to content

Renderer null check fix in solaraviz #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Sahil-Chhoker
Copy link
Collaborator

Explicity check if the renderer is None or not in SolaraViz.
Normal check was causing a error on the solara interface.

@Sahil-Chhoker Sahil-Chhoker requested a review from tpike3 July 10, 2025 05:47
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +1.6% [+0.8%, +2.5%] 🔵 -0.7% [-0.8%, -0.6%]
BoltzmannWealth large 🔵 +0.2% [-0.2%, +0.6%] 🔵 -0.9% [-2.2%, +0.4%]
Schelling small 🔵 -0.1% [-0.2%, +0.1%] 🔵 -0.3% [-0.4%, -0.1%]
Schelling large 🔵 -0.6% [-3.9%, +2.5%] 🔵 -1.8% [-2.4%, -1.2%]
WolfSheep small 🔵 -0.3% [-0.6%, -0.1%] 🔵 -0.5% [-0.6%, -0.3%]
WolfSheep large 🔵 -0.1% [-0.8%, +0.8%] 🔵 -0.7% [-1.4%, -0.1%]
BoidFlockers small 🔵 +0.7% [+0.3%, +1.1%] 🔵 +0.7% [+0.5%, +0.9%]
BoidFlockers large 🔵 +1.7% [+1.1%, +2.4%] 🔵 +1.2% [+0.9%, +1.6%]

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit f9e6dbb into projectmesa:main Jul 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants