Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace colord with colorjs.io to support more colors #76

Merged
merged 9 commits into from
Jul 28, 2024

Conversation

bartveneman
Copy link
Member

closes #52

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Bundle Report

Changes will increase total bundle size by 122.04kB ⬆️

Bundle name Size Change
formatCss-colorSorter-esm 86.91kB 74.63kB ⬆️
formatCss-colorSorter-esm-colorSorter-umd 57.46kB 47.41kB ⬆️

Copy link

codspeed-hq bot commented Jul 4, 2024

CodSpeed Performance Report

Merging #76 will degrade performances by 97.1%

Comparing wider-color-gamuts (0071236) with master (5cb7045)

Summary

⚡ 1 improvements
❌ 15 (👁 15) regressions

Benchmarks breakdown

Benchmark master wider-color-gamuts Change
👁 convert hex 45.6 µs 191.8 µs -76.24%
👁 convert hsl() 56.9 µs 176.7 µs -67.81%
👁 convert hsl() (modern syntax) 57.9 µs 176.4 µs -67.2%
convert hsla() 308.2 µs 200.1 µs +54.02%
👁 convert hsla() (modern syntax) 64.5 µs 185 µs -65.12%
👁 convert invalid color 42.9 µs 173.9 µs -75.34%
👁 convert named color 54.5 µs 170.5 µs -68.03%
👁 convert oklch() 43.1 µs 232.4 µs -81.44%
👁 convert rgb() 49.6 µs 208.3 µs -76.2%
👁 convert rgb() (modern syntax) 50.8 µs 204.4 µs -75.14%
👁 convert rgba() 52.3 µs 208.6 µs -74.91%
👁 convert rgba() (modern syntax) 53.6 µs 210.6 µs -74.55%
👁 convert system color 44.6 µs 170.9 µs -73.88%
👁 convert transparent 52.1 µs 169 µs -69.16%
👁 real world sort example #1 927.1 µs 31,924.8 µs -97.1%
👁 real world sort example #2 (nerdy.dev) 7 ms 56.5 ms -87.56%

@bartveneman bartveneman changed the title support oklch and friends replace colord with colorjs.io to support more colors Jul 28, 2024
@bartveneman bartveneman merged commit 50ecb33 into master Jul 28, 2024
6 checks passed
@bartveneman bartveneman deleted the wider-color-gamuts branch July 28, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

support modern color spaces
2 participants