Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Add instance label information to the prometheusrule description #5041

Conversation

daviderli614
Copy link
Contributor

@daviderli614 daviderli614 commented Dec 5, 2024

What this PR does / why we need it

I found that the description in the prometheusrule of NodeHighNumberConntrackEntriesUsed and node-network lacks the instance label. Adding this label helps to know the specific alarm instance.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@daviderli614 daviderli614 force-pushed the chore/rule-instance-label branch from 8cf9c6c to 38cc9fb Compare December 5, 2024 15:41
@daviderli614 daviderli614 changed the title chore: Add instance label information to the prometheusrule description [kube-prometheus-stack] Add instance label information to the prometheusrule description Dec 5, 2024
@GMartinez-Sisti
Copy link
Member

Hi @daviderli614, please check the header of the files you are changing. There is a specific procedure to update these.

@daviderli614
Copy link
Contributor Author

daviderli614 commented Dec 5, 2024

Hi @daviderli614, please check the header of the files you are changing. There is a specific procedure to update these.

@GMartinez-Sisti
I modified kube-prometheus, what do I need to modify here next and then run sync_prometheus_rules.py ?
I need to modify this repository? https://github.com/kubernetes-monitoring/kubernetes-mixin

@jkroepke
Copy link
Member

jkroepke commented Dec 5, 2024

Yeah that should be sufficient

@daviderli614
Copy link
Contributor Author

daviderli614 commented Dec 6, 2024

I want to wait until kube-prometheus is merged before modifying here.

@jkroepke
Copy link
Member

jkroepke commented Dec 6, 2024

Yeah, that mandatory. Otherwise, the changes from this PR may get reverted by scripts.

Copy link

stale bot commented Feb 1, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Feb 1, 2025
Copy link

stale bot commented Feb 25, 2025

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants