This repository was archived by the owner on Aug 13, 2019. It is now read-only.
Isolation #105
Closed
Isolation #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Appears this now has merge conflicts. Mind rebasing? |
Contributor
|
I'm currently doing some work to make the hot path of creating new series lock free. We are currently seeing rather heavy contention whenever new series are created (first startup, targets added/swapped, new head block created), which causes some notable drops in ingestion for larger servers. This basically requires isolation as well, so I currently have some pending work doing the same thing. I'm trying to avoid leaking this into our nicely simple APIs. Rebasing might be a bit of unnecessary work right now. |
Open
Contributor
Author
|
Superseded by #306 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core part of prometheus/prometheus#1893
Initial prombench benchmarks indicate a ~5% cpu hit and ~11% RAM hit, which I consider reasonable for this feature. I haven't done any micro-optimisations.
There's some cleanup work to be done here still, but I figured it's best to get some initial review.