Support GCP Web Identity session credentials #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Lafferty <[email protected]>
connor-scio
force-pushed
the
glean-cloudwatch_exporter-1.0
branch
from
7888b79
to
28bc50e
Compare
matthiasr
reviewed
Mar 3, 2024
There was a problem hiding this comment.
I think I understand what this is about, but I am not sure. Could you please add a bit more description to the PR, as well as documentation of the configuration and how to use it to the README?
You don't have to implement other providers, but I would like to make sure we are not limiting future options: Can you briefly explain how we would extend this to support other providers' web identity integrations in the future?
| private AwsCredentialsProvider getRoleCredentialProvider(Map<String, Object> config) { | ||
| String roleArn = (String) config.get("role_arn"); | ||
| if (config.containsKey("assume_role_web_identity")) { |
There was a problem hiding this comment.
Since this only works for GCP, I think this config key should reflect it?
|
Also, please add the DCO sign-off to all your commits, it is a legal requirement for us to accept your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.