Deprecate this exporter #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://groups.google.com/u/3/g/prometheus-developers/c/0yr5HI6va8M/m/Ftxw3mrcAgAJ Signed-off-by: Julien Pivotto <[email protected]>
SuperQ
approved these changes
Jan 26, 2021
|
looks good to me. |
juliusv
reviewed
Jan 26, 2021
| [][quay] | ||
| [][hub] | ||
| We recommend our users to use the [write_prometheus](https://collectd.org/wiki/index.php/Plugin:Write_Prometheus) | ||
| plugin from collected instead of this exporter. This plugin is similar in scope |
There was a problem hiding this comment.
Suggested change
| plugin from collected instead of this exporter. This plugin is similar in scope | |
| plugin from collectd instead of this exporter. This plugin is similar in scope |
|
Hm, did we decide on that now? My last PR on this still had some concerns from people around speed and TLS. |
|
The earlier PR was: #96 |
|
oh I missed that. closing per #96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://groups.google.com/u/3/g/prometheus-developers/c/0yr5HI6va8M/m/Ftxw3mrcAgAJ
Signed-off-by: Julien Pivotto [email protected]