Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an inline OM created timestamp syntax #760

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Maniktherana
Copy link

this PR aims to update the created timestamp syntax as outlined in the following proposal: prometheus/proposals#43

Signed-off-by: Manik Rana <[email protected]>
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for starting this!

I think we may want a different approach though, OpenMetrics 1.0 is not going away, so we need to keep the _created lines for users of that version of the protocol.

What we want is a separate implementation for 2.0.

@Maniktherana
Copy link
Author

Nice, thanks for starting this!

I think we may want a different approach though, OpenMetrics 1.0 is not going away, so we need to keep the _created lines for users of that version of the protocol.

What we want is a separate implementation for 2.0.

understood, how can we manage both implementations together? Do we use a feature flag for this?

@ArthurSens
Copy link
Member

Feedback from our call:

Clients who use prometheus/common to encode data use NewEncoder and it returns a different encoder based on Content Type.

We can try two options and see what works best:

  • Create a totally new encoder MetricFamilyToOpenMetrics2.0
    or
  • The existing MetricFamilyToOpenMetrics encoder could have a new encoder option that decides its version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants