collector/zfs: consistent metric names #3025
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow APIs to be gated conditionally. Signed-off-by: Pranshu Srivastava <[email protected]>
Make metric names between `freebsd` and `linux` consistent. This is gated behind the `ConsistentZFSLinuxMetricNames` gate, and disabled by default. Fixes: prometheus#1945 Signed-off-by: Pranshu Srivastava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make metric names between
freebsdandlinuxconsistent. This isgated behind the
ConsistentZFSLinuxMetricNamesgate, and disabledby default.
Fixes: #1945
Blocked-by: #3024
Signed-off-by: Pranshu Srivastava [email protected]