Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compilation for Python 3.12 #160

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Add compilation for Python 3.12 #160

merged 3 commits into from
Jan 22, 2024

Conversation

Swandog
Copy link
Contributor

@Swandog Swandog commented Jan 12, 2024

This uses the changes from @schmidmt branch ci/python3.12
but without the manual arrow dependency installation
Since that branch was made, the Polars project has started officially supporting 3.12 I figured we should try this again with the bare minimum of changes

@Swandog Swandog requested a review from a team as a code owner January 12, 2024 00:00
@Swandog Swandog self-assigned this Jan 12, 2024
@Swandog Swandog requested a review from schmidmt January 12, 2024 00:00
@Swandog
Copy link
Contributor Author

Swandog commented Jan 12, 2024

Looks like the audit is gonna require an upgrade of Polars in Rust...I tried that and it broke, so this may take more work

@schmidmt schmidmt added enhancement New feature or request Python Pertains to the Python API labels Jan 16, 2024
This uses the changes from @schmidmt branch `ci/python3.12`
  but without the manual arrow dependency installation
Since that branch was made, the Polars project has started officially supporting 3.12
I figured we should try this again with the bare minimum of changes
@schmidmt schmidmt force-pushed the ci/python3.12-attempt-2 branch from 4427ffb to a350660 Compare January 19, 2024 16:02
Swandog and others added 2 commits January 19, 2024 16:36
Updated the version of Polars in Rust to 0.36. Necessary fixes:
The `min`/`max` methods now return a `Result<Option>`, with the `Err` being returned
  if the cast fails (previously it was discarded)
Polars changed the name of `DataType::UTF8` to `DataType::String`
Updated:
* pyo3
* polars
* polars-arrow

Removed unused dependencies.
@schmidmt schmidmt force-pushed the ci/python3.12-attempt-2 branch from 670b077 to 89db686 Compare January 20, 2024 04:19
Copy link
Contributor

@schmidmt schmidmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Swandog Swandog merged commit a4050eb into master Jan 22, 2024
25 checks passed
@Swandog Swandog deleted the ci/python3.12-attempt-2 branch January 22, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python Pertains to the Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants