Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed error when appending to boolean columns. #162

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

schmidmt
Copy link
Contributor

Addresses #161 by adding match for allow appending booleans to any boolean categorical column inside maybe_add_category.

@schmidmt schmidmt added bug Something isn't working Rust Pertains to the Rust API labels Jan 17, 2024
@schmidmt schmidmt self-assigned this Jan 17, 2024
@schmidmt schmidmt requested a review from a team as a code owner January 17, 2024 21:59
@schmidmt schmidmt linked an issue Jan 17, 2024 that may be closed by this pull request
Copy link
Contributor

@BaxterEaves BaxterEaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Addresses #161 by adding match for allow appending booleans to any boolean categorical column inside `maybe_add_category`.
@schmidmt schmidmt merged commit fe07182 into master Jan 19, 2024
23 checks passed
@schmidmt schmidmt deleted the fix/append-to-bool branch May 6, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Rust Pertains to the Rust API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot insert boolean categorical data
2 participants