Regenerated the index.hbs theme file to handle mobile sites
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something changed with the MDBook theme that caused it to not render properly on mobile. Specifically, the site would come up with the sidebar open and the "close" button would not work. I fixed this by initializing a NEW MDBook, copying over the generated `index.hbs`, and then adding in the changes we have made to our `index.hbs` in the Lace Git History. Now it works correctly on the Firefox Mobile WebDev tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the mobile site.
!!!NOTE TO REVIEWERS!!!: I fixed this by creating a new MDBook, then taking all of its contents and moving into the
book/themedirectory. Then, I looked at the changes that had been made toindex.hbsthroughout the Lace Git Repository history, and copied them onto the newly generatedindex.hbs.THIS MEANS: if there were any changes made to the theme from BEFORE the Lace git repo was set up (namely, while it was Braid), then those changes will not be reflected in this new directory. Specifically,
index.hbsdone back in the Braid repository, they were not copied hereThat said, this change seems to work. You can test it by running
cargo install mdbook && mdbook serve book