458 fix wasm #519
458 fix wasm #519
Conversation
|
From a quick glance, looks good, although it's been open for a long time, so would be good to test it still works. |
| #[cfg(feature = "std")] | ||
| const MAX_SHRINK_ITERS: &str = "PROPTEST_MAX_SHRINK_ITERS"; | ||
| #[cfg(feature = "std")] | ||
| const MAX_DEFAULT_SIZE_RANGE: &str = "PROPTEST_MAX_DEFAULT_SIZE_RANGE"; |
There was a problem hiding this comment.
did this one get deleted on accident? i believe it's still in use in parse_or_warn
There was a problem hiding this comment.
Idk - it's been a very long time - but CI seems to pass?
There was a problem hiding this comment.
odd
Variable `MAX_DEFAULT_SIZE_RANGE` should have snake_case name, e.g. `max_default_size_range`
so arbitrary tokens in pattern match positions seem to be treated as new variable bindings and default to (), that's why this still compiles even though there's a warning.
i don't think i have push access to this branch though so @matthew-russo you'll need to update please
There was a problem hiding this comment.
so arbitrary tokens in pattern match positions seem to be treated as new variable bindings and default to (), that's why this still compiles even though there's a warning.
Hm but that doesn't explain why parse_or_warn accepted it if it's () and used in an argument that expects &str.
There was a problem hiding this comment.
pushed an updated commit that has this
Hides a few paths, that fail at runtime on wasm32-unknown-unknown, under conditional compilation. Fixes proptest-rs#137.
matthew-russo
force-pushed
the
458-fix-wasm
branch
from
a105c7a
to
0585e03
Compare
replaces #458