Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color of selected country in footer #92

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

piperchester
Copy link
Contributor

@piperchester piperchester commented Oct 18, 2020

When selected, the country is difficult to read in the footer:

Screen Shot 2020-10-18 at 7 55 15 AM

This is a tiny PR to make the selected color white.

Also,

  • Added install instructions to CONTRIBUTING.md
  • Removed extraneous period from selected country (was a subjective call; happy to back this out if undesired!)

This project is fantastic and I'm a big fan. @ maintainers, would it be possible for me to get push permissions so that I don't need to fork the repo to contribute?

@philsturgeon philsturgeon merged commit 77f21a3 into protect-earth:main Oct 20, 2020
@philsturgeon
Copy link
Collaborator

Thank you! The selected country doesn't work too well right now, and our plans for a rewrite have gone up in smoke due to inactivity. Life is hard and people have jobs, so it happens. Do you think you could take a stab at #28 for this gatsby based site?

@piperchester
Copy link
Contributor Author

Thank you! The selected country doesn't work too well right now, and our plans for a rewrite have gone up in smoke due to inactivity. Life is hard and people have jobs, so it happens. Do you think you could take a stab at #28 for this gatsby based site?

Yes! I can take a look.

Wildly unrelated, do you think there's value in getting protect.earth into hacktoberfest?

@philsturgeon
Copy link
Collaborator

We're probably about to merge protect.earth with climatechoice.co which will require a fair bit of open-source help. We had some plants to do things rather differently for a while but at this point I think the plan is to make an airtable, switch this v1 over to https://www.gatsbyjs.com/plugins/gatsby-source-airtable/, then we can use that same table to power the directory on climatechoice.co (or whichever other directory we merge with) and we can then deprecate the directory on our site as protect.earth starts to focus on reforestation.

If you'd be willing to help with any of all of the above that'd be amazing, but I'd hate for anyone to labor under false pretenses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants