-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the Unified CI part of this PR. I can't comment on the JS workflow, I'll leave that to the other reviewers.
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: lts/* | ||
- uses: ipfs/aegir/actions/cache-node-modules@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action doesn't have to live in the aegir
repo - when we're happy with the workflow it could be moved here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also make a separate repo for it if we want to put it on the marketplace - similarly to what we did here https://github.com/protocol/cache-go-action. For now though, we can leave it in ipfs/aegir
.
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
{ "target": "ipfs/js-blockstore-core" }, | ||
{ "target": "libp2p/js-libp2p-crypto" }, | ||
{ "target": "libp2p/js-libp2p-interfaces" }, | ||
{ "target": "libp2p/js-libp2p-tcp" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ "target": "libp2p/js-libp2p-tcp" } | |
{ "target": "libp2p/js-libp2p-tcp" }, | |
{ "target": "alanshaw/it-pipe" }, | |
{ "target": "alanshaw/it-goodbye" } |
vasco-santos/is-loopback-addr should also be in here but it's primary branch is called main
and not master
so I guess #262 needs merging first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that these repos will need to grant permissions to the web3-bot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't have to wait for #262 because $default-branch
string is already replaced in our templated with a name of the default branch. #262 only generalises the templating approach.
As for more repos, how about we start with the original 4 to make sure the setup works as expected first? @achingbrain Could you check if web3-bot
is allowed to write to ipfs/js-blockstore-core#14? I don't have access to settings in that repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, gotcha.
I've added web3-bot
to blockstore-core and the stewards team, @alanshaw is doing his various it-* repos.
Happy to merge this without the extra repos - since the bot is gaining perms we can add them later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is someone monitoring the web3-bot
inbox for repo invites? They have to be manually approved by web3-bot
if you're not adding it to a repo from an org it's already a member of.
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
Co-authored-by: Alex Potsides <[email protected]>
* deploy JS unified CI script * trust workflows published in ipfs org * use hash for codecov action * use actions/checkout@v2 in the js workflow * use codecov/[email protected] in the js workflow * Apply codecov suggestions from code review Co-authored-by: Alex Potsides <[email protected]> Co-authored-by: Alex Potsides <[email protected]>
* deploy JS unified CI script * trust workflows published in ipfs org * use hash for codecov action * use actions/checkout@v2 in the js workflow * use codecov/[email protected] in the js workflow * Apply codecov suggestions from code review Co-authored-by: Alex Potsides <[email protected]> Co-authored-by: Alex Potsides <[email protected]>
Resolves #235
Resolves #273
Description
In this PR I create a new JSON config for JS repos, copy the JS CI workflow created by @achingbrain to the templates directory and configure unified CI for JS repositories that were mentioned here #273 (comment).
Testing
This is now happily running on typescript, pure-ESM, node-js only and monorepo projects. - #273 (comment)