Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

deploy JS unified CI script #274

Merged
merged 6 commits into from
Jan 13, 2022
Merged

deploy JS unified CI script #274

merged 6 commits into from
Jan 13, 2022

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Jan 10, 2022

Resolves #235
Resolves #273

Description

In this PR I create a new JSON config for JS repos, copy the JS CI workflow created by @achingbrain to the templates directory and configure unified CI for JS repositories that were mentioned here #273 (comment).

Testing

This is now happily running on typescript, pure-ESM, node-js only and monorepo projects. - #273 (comment)

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the Unified CI part of this PR. I can't comment on the JS workflow, I'll leave that to the other reviewers.

configs/js.json Show resolved Hide resolved
templates/.github/workflows/js-test-and-release.yml Outdated Show resolved Hide resolved
- uses: actions/setup-node@v2
with:
node-version: lts/*
- uses: ipfs/aegir/actions/cache-node-modules@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action doesn't have to live in the aegir repo - when we're happy with the workflow it could be moved here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also make a separate repo for it if we want to put it on the marketplace - similarly to what we did here https://github.com/protocol/cache-go-action. For now though, we can leave it in ipfs/aegir.

galargh added a commit to galargh/js-blockstore-core that referenced this pull request Jan 11, 2022
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
galargh added a commit to libp2p/js-libp2p-interfaces that referenced this pull request Jan 11, 2022
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
galargh added a commit to libp2p/js-libp2p-tcp that referenced this pull request Jan 11, 2022
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
achingbrain pushed a commit to libp2p/js-libp2p-interfaces that referenced this pull request Jan 11, 2022
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
achingbrain pushed a commit to libp2p/js-libp2p-tcp that referenced this pull request Jan 11, 2022
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
achingbrain pushed a commit to libp2p/js-libp2p-crypto that referenced this pull request Jan 11, 2022
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
{ "target": "ipfs/js-blockstore-core" },
{ "target": "libp2p/js-libp2p-crypto" },
{ "target": "libp2p/js-libp2p-interfaces" },
{ "target": "libp2p/js-libp2p-tcp" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ "target": "libp2p/js-libp2p-tcp" }
{ "target": "libp2p/js-libp2p-tcp" },
{ "target": "alanshaw/it-pipe" },
{ "target": "alanshaw/it-goodbye" }

vasco-santos/is-loopback-addr should also be in here but it's primary branch is called main and not master so I guess #262 needs merging first?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these repos will need to grant permissions to the web3-bot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't have to wait for #262 because $default-branch string is already replaced in our templated with a name of the default branch. #262 only generalises the templating approach.

As for more repos, how about we start with the original 4 to make sure the setup works as expected first? @achingbrain Could you check if web3-bot is allowed to write to ipfs/js-blockstore-core#14? I don't have access to settings in that repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, gotcha.

I've added web3-bot to blockstore-core and the stewards team, @alanshaw is doing his various it-* repos.

Happy to merge this without the extra repos - since the bot is gaining perms we can add them later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is someone monitoring the web3-bot inbox for repo invites? They have to be manually approved by web3-bot if you're not adding it to a repo from an org it's already a member of.

galargh added a commit to ipfs/js-blockstore-core that referenced this pull request Jan 12, 2022
Rename `main.yml` to `js-test-and-release.yml` so that unified CI introduced in protocol/.github#274 can take over the workflow's management.
@galargh galargh merged commit 1b5b0e8 into master Jan 13, 2022
@galargh galargh deleted the js-unified-ci branch January 13, 2022 11:45
galargh added a commit that referenced this pull request Jan 13, 2022
* deploy JS unified CI script

* trust workflows published in ipfs org

* use hash for codecov action

* use actions/checkout@v2 in the js workflow

* use codecov/[email protected] in the js workflow

* Apply codecov suggestions from code review

Co-authored-by: Alex Potsides <[email protected]>

Co-authored-by: Alex Potsides <[email protected]>
galargh added a commit that referenced this pull request Jan 13, 2022
* deploy JS unified CI script

* trust workflows published in ipfs org

* use hash for codecov action

* use actions/checkout@v2 in the js workflow

* use codecov/[email protected] in the js workflow

* Apply codecov suggestions from code review

Co-authored-by: Alex Potsides <[email protected]>

Co-authored-by: Alex Potsides <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS unified CI script Setting up unified CI for js repos
3 participants