[PHP] Fix locale-dependent JSON float encoding (#18808) #25329
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `sprintf` with `%h` specifier to format float and double values. This ensures the decimal separator is always a dot (.), regardless of the system's current locale settings (e.g. de_DE). This fixes an issue where floats were serialized with commas (e.g. "3,14") resulting in invalid JSON. Fixes protocolbuffers#18808
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bshaffer
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #18808 regarding locale-dependent JSON serialization in PHP.
Problem
When the system environment is set to a locale that uses a comma as a decimal separator (like
de_DE),floatanddoublevalues were being serialized into JSON as3,14instead of3.14. This produced invalid JSON that could not be parsed by other systems.Solution
sprintf("%.*h", ...)for formatting values. This ensures that the decimal separator is always a dot (.), making the output locale-independent.de_DEto verify that the fix works correctly and produces valid JSON.Verification
vendor/bin/phpunit php/tests/EncodeDecodeTest.phpFixes #18808