Skip to content

Change kind attribute of OSMData sourced-water to ocean #746

Change kind attribute of OSMData sourced-water to ocean

Change kind attribute of OSMData sourced-water to ocean #746

Re-run triggered November 6, 2024 22:07
Status Success
Total duration 4m 26s
Artifacts

sonar.yml

on: pull_request
Analyze with Sonar
4m 15s
Analyze with Sonar
Fit to window
Zoom out
Zoom in

Annotations

2 warnings
Analyze with Sonar
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-java@v3, actions/cache@v3, actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
CRITICAL CODE_SMELL: src/main/java/com/protomaps/basemap/layers/Water.java#L28
Define a constant instead of duplicating this literal "ocean" 5 times. rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192) issue url: https://sonarcloud.io/project/issues?pullRequest=330&open=AZMDhqeT5eFFdtgHD8NP&id=protomaps_basemaps