Clip tileset to a polygonal boundary #798
bdonsonar.yml
on: pull_request
Analyze with Sonar
1m 23s
Annotations
11 warnings
|
Analyze with Sonar
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/Basemap.java#L21
Remove this unused import 'java.io.IOException'.
rule: java:S1128 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1128&rule_key=java%3AS1128)
issue url: https://sonarcloud.io/project/issues?pullRequest=351&open=AZRKC9AlsfMZLFhp-2B7&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/Basemap.java#L22
Remove this unused import 'java.nio.file.Files'.
rule: java:S1128 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1128&rule_key=java%3AS1128)
issue url: https://sonarcloud.io/project/issues?pullRequest=351&open=AZRKC9AlsfMZLFhp-2B8&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/Basemap.java#L24
Remove this unused import 'java.nio.file.Paths'.
rule: java:S1128 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1128&rule_key=java%3AS1128)
issue url: https://sonarcloud.io/project/issues?pullRequest=351&open=AZRKC9AlsfMZLFhp-2B9&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/GeoJSON.java#L14
Add a private constructor to hide the implicit public one.
rule: java:S1118 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1118&rule_key=java%3AS1118)
issue url: https://sonarcloud.io/project/issues?pullRequest=351&open=AZRKC9AzsfMZLFhp-2CC&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/postprocess/Clip.java#L41
This block of commented-out lines of code should be removed.
rule: java:S125 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS125&rule_key=java%3AS125)
issue url: https://sonarcloud.io/project/issues?pullRequest=351&open=AZRKC9AssfMZLFhp-2B_&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/postprocess/Clip.java#L46
Define and throw a dedicated exception instead of using a generic one.
rule: java:S112 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS112&rule_key=java%3AS112)
issue url: https://sonarcloud.io/project/issues?pullRequest=351&open=AZRKC9AssfMZLFhp-2B-&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/postprocess/Clip.java#L99
Refactor this method to reduce its Cognitive Complexity from 82 to the 15 allowed.
rule: java:S3776 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS3776&rule_key=java%3AS3776)
issue url: https://sonarcloud.io/project/issues?pullRequest=351&open=AZRKC9AssfMZLFhp-2CA&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/postprocess/Clip.java#L143
Replace this use of System.err by a logger.
rule: java:S106 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS106&rule_key=java%3AS106)
issue url: https://sonarcloud.io/project/issues?pullRequest=351&open=AZRKC9AssfMZLFhp-2CB&id=protomaps_basemaps
|
|
BLOCKER CODE_SMELL:
src/test/java/com/protomaps/basemap/GeoJSONTest.java#L3
Add some tests to this class.
rule: java:S2187 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS2187&rule_key=java%3AS2187)
issue url: https://sonarcloud.io/project/issues?pullRequest=351&open=AZRKC8_rsfMZLFhp-2B5&id=protomaps_basemaps
|
|
BLOCKER CODE_SMELL:
src/test/java/com/protomaps/basemap/postprocess/ClipTest.java#L3
Add some tests to this class.
rule: java:S2187 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS2187&rule_key=java%3AS2187)
issue url: https://sonarcloud.io/project/issues?pullRequest=351&open=AZRKC9ALsfMZLFhp-2B6&id=protomaps_basemaps
|