Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use station tag value in pmap:kind_detail and include tram stops in POIs #166

Closed
wants to merge 8 commits into from
Closed

Use station tag value in pmap:kind_detail and include tram stops in POIs #166

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a01c01b
Use station tag value in pmap:kind_detail to differentiate subway / l…
eikes Oct 26, 2023
d1ff93e
Include tram stops in POIs as well
eikes Oct 26, 2023
6c70839
Show train station at 13, subway and light rail station at 14 and tra…
eikes Oct 29, 2023
06e2387
Add "railway: halt" and set minZoom to 14
eikes Oct 29, 2023
3369649
Merge branch 'main' into station-detail
eikes Nov 1, 2023
8df8aa5
Apply spotless maven
eikes Nov 4, 2023
51525aa
Apply maven spotless again : D
eikes Nov 4, 2023
03bf500
remove trailing spaces
eikes Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tiles/src/main/java/com/protomaps/basemap/layers/Pois.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public void processFeature(SourceFeature sf, FeatureCollector features) {
sf.hasTag("leisure") ||
sf.hasTag("natural", "beach") ||
sf.hasTag("railway", "station") ||
sf.hasTag("railway", "tram_stop") ||
sf.hasTag("shop") ||
sf.hasTag("tourism") &&
(!sf.hasTag("historic", "district")))) {
Expand Down Expand Up @@ -204,6 +205,8 @@ public void processFeature(SourceFeature sf, FeatureCollector features) {
kindDetail = sf.getString("religion");
} else if (sf.hasTag("sport")) {
kindDetail = sf.getString("sport");
} else if (sf.hasTag("station")) {
kindDetail = sf.getString("station");
}

// try first for polygon -> point representations
Expand Down