Fix Antarctica landcover #342
Conversation
|
Bonus points if you also fix up northern Greenland, north of around 82.8° N, the other common area people complain about: 
|
| @@ -29,6 +30,19 @@ public void processNe(SourceFeature sf, FeatureCollector features) { | |||
| } else if (sourceLayer.equals("ne_10m_land")) { | |||
| features.polygon(this.name()).setZoomRange(5, 5).setBufferPixels(8).setAttr("kind", "earth"); | |||
| } | |||
| if (sourceLayer.equals("ne_10m_glaciated_areas")) { | |||
There was a problem hiding this comment.
This section deserves a comment explaining the problem and why this particular solution works
There was a problem hiding this comment.
Added one, thanks for the tip!
| if (sourceLayer.equals("ne_10m_glaciated_areas")) { | ||
| try { | ||
| Point centroid = (Point) sf.centroid(); | ||
| if (centroid.getY() > 0.7) { |
There was a problem hiding this comment.
This works, but it's confusing this isn't a negative number, and 70 would normally not result in the northern tip of Chilean Antarctica (many international bases there) showing up correctly as ice.
Please add a comment explaining that you're targeting ice features in Antarctica south of -60°.
There was a problem hiding this comment.
Web Mercator Y in Planetiler goes from 0 to 1 from 85 deg N to 85 deg S. The equator is at Web Mercator Y = 0.5
|
I tried Greenland with something like |
|
|
Comments look good! For Greenland, make a fake rectangle of glacier in just that area? That would look better than the grey. But a nit, can merge this as-is. |
Fixes #337
https://maps.protomaps.com/#map=0.97/-10.8/-17.6&theme=light&lang=en&tiles=https://protomaps.dev/~wipfli/antarctica.pmtiles