Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

places grid #437

Merged
merged 11 commits into from
Apr 2, 2025
Merged

places grid #437

merged 11 commits into from
Apr 2, 2025

Conversation

wipfli
Copy link
Collaborator

@wipfli wipfli commented Mar 27, 2025

Copies the pre-collide changes from #300 over to latest main.

Comment on lines 218 to 220
7, 24,
8, 32,
9, 32,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed that some features are present in zoom 7, then they disappear at zoom 8, and reappear at zoom 9:

Example Toulon

Zoom 7 many points in orange circles:

image

Zoom 8 only one point for Toulon:

image

Zoom 9 many points reappear:

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is due to the increase in the label grid cell size. Larger cell means more features fall into the same cell means fewer are retained...

@wipfli
Copy link
Collaborator Author

wipfli commented Apr 2, 2025

Here is a jsbin showing the difference to main. Orange disks are from main, and red points are from this branch:

https://jsbin.com/libevelixe/1/edit?html,output

image

@wipfli
Copy link
Collaborator Author

wipfli commented Apr 2, 2025

Copy link

sonarqubecloud bot commented Apr 2, 2025

@wipfli wipfli merged commit 7fba700 into main Apr 2, 2025
5 checks passed
@wipfli wipfli deleted the places-grid branch April 2, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants