Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui: Fix French Translations #3089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gui: Fix French Translations #3089

wants to merge 1 commit into from

Conversation

RJRP44
Copy link

@RJRP44 RJRP44 commented May 28, 2023

During my prusa experience, I found some strange or missing French translations.
I hope this helps

@Maxime-JULLIEN
Copy link

@Prusa-Support Could you allow this merge please ? The translation is good !

@bkerler bkerler mentioned this pull request Dec 21, 2023
Closed
@bkerler
Copy link
Contributor

bkerler commented Dec 21, 2023

Hi !
Looks good to me as well. Did you test the changed translations on the device or on the simulator ?
If not, then I can do the tests for you and post screenshots here for the UX team of prusa.

Also, can you please change the subject of this PR to "gui: Fix French Translations" ?

@RJRP44 RJRP44 changed the title Fix French Translations gui: Fix French Translations Dec 22, 2023
@danopernis danopernis added the translations language packages label Mar 14, 2024
@bkerler bkerler mentioned this pull request Mar 29, 2024
Closed
@RJRP44
Copy link
Author

RJRP44 commented Mar 30, 2024

Hi !
Sorry for this very long response time (I almost forgot about this PR), I tried but not successfully to run it on the simulator. @bkerler if you can do it for me, I would be delighted.
Thanks in advance !

@bkerler
Copy link
Contributor

bkerler commented Mar 30, 2024

Bien sûr ;)

@michalrudolf michalrudolf added the scheduled We are working on it or we have scheduled it for one of the next releases. label Jul 24, 2024
3wnbr1
3wnbr1 reviewed Jan 2, 2025
View reviewed changes
src/lang/po/fr/Prusa-Firmware-Buddy_fr.po
@@ -35,7 +35,7 @@ msgstr ""
#. window_menu
#: src/gui/MItem_tools.cpp:287
msgid "A crash dump is being saved."
msgstr "Un dump sur crash est en cours d'enregistrement."
msgstr "Un rapport de vidage de mémoire est en cours d'enregistrement."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does crash dump really need to be translated ? I don't find rapport de vidage de mémoire very clear. It would be translated back to English as memory dump report which differs from crash dump

If you still want to translate it, I would suggest Une image mémoire est en cours d'enregistrement.
From https://fr.wikipedia.org/wiki/Analyse_d%27images_mémoire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3wnbr1 3wnbr1 3wnbr1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
scheduled We are working on it or we have scheduled it for one of the next releases. translations language packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RJRP44 @Maxime-JULLIEN @bkerler @3wnbr1 @danopernis @michalrudolf