optimisation: set enum types explictly to uint8_t
#328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
3d-gussner
force-pushed
the
optimise-enums
branch
from
7c59f3d to
75f9608
Compare
Automated Test Code Coverage ReportView details...
TOTAL: 2727 lines of code, 2030 lines executed, 74% covered. |
This commit produces the same savings as the compiler options -fshort-enums. Except by setting the types manually we save also 2 bytes of SRAM. By default, the enum type is 2 bytes, with we can explictly set it to one byte when applicable to reduce code size. Almost all the savings from from 'enum Mode' in leds.h. Change in memory: Flash: -116 bytes SRAM: -2 bytes
gudnimg
force-pushed
the
optimise-enums
branch
from
75f9608 to
ccb7d31
Compare
|
Rebased to sync with main. Will merge if all CI checks pass again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit produces the same savings as the compiler option
-fshort-enums. Except by setting the types manually we save also 2 bytes of SRAM.By default, the
enumtype is 2 bytes, we can explicitly set it to one byte when applicable to reduce code size.Almost all the savings come from
enum Modein leds.h.Change in memory:
Flash: -116 bytes
SRAM: -2 bytes