Make image_build.py more portable #1019
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues that might occur in `image_builder.py` (the RPi image builder). In particular: * Set the `rev` for `pishrink.sh` to ensure a known working version is used * Drops the (non-existent?) `-p` parameter of `pishrink.sh` and disable autoupdate checks (`-n`) * Use `curl` instead of `wget` (more widespread) * Add attempt logs for `run_emulator` as well as a check to ensure the `qemu` process hasn't died * Change some `qemu` args to ensure the script can be run on headless systems * Add `-y` to `e2fsck` to default all answers to "yes"
|
@TojikCZ thoughts on this? |
|
Hey, thank you for improving the script. Sorry we don't have any time for PrusaLink. I hope we'll get to transition the repo under @3d-gussner supervision, but there's no clear timeline for that. |
|
Hey @TojikCZ @3d-gussner, I was wondering if you had news re. the future of PrusaLink? Will Prusa stop maintaining it? Not committing to anything, but @Rudd-O and I both rely on it and would be happy to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues that might occur in
image_builder.py(the RPi image builder). In particular:revforpishrink.shto ensure a known working version is used-pparameter ofpishrink.shand disable autoupdate checks (-n)curlinstead ofwget(more widespread)run_emulatoras well as a check to ensure theqemuprocess hasn't diedqemuargs to ensure the script can be run on headless systems-ytoe2fsckto default all answers to "yes"