allow plugin to continue operating if assert()
is non-fatal
#47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments,
assert()
can be configured to be non-fatal, which causes the plugin to error out when$param->type
is passed to a function that expectsType\Union
.Setting the type via
Type::getMixed()
(being the equivalent of "unknown" in this particular case) allows the plugin to continue executing, while the assertion still gets logged.When assertions are fatal, no change in behaviour is expected as the plugin should bail out right away.