Combine f-strings which would be placed on the same line #4480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey! First time contributing to the project so please let me know if I'm doing anything wrong here :)
I've implemented changes for the issue described here #4389
Esentially if we can combine multiple f-strings into a single f-string without breaking other considerations like the intended line length then I attempt to do so. This is done by breaking apart the AST of multiple f-strings into a single f-string node by only keeping the first
FSTRING_START
token and the lastFSTRING_END
token and keeping all tokens inbetween.Checklist - did you ...
I've added 2 new test cases showing that the examples in the issue are fixed by the change. All other tests are passing which indicates that the change does not affect other cases.
CHANGES.md
if necessary?