Generate wrappers #623
Merged
Generate wrappers #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uli Schlachter <[email protected]>
Signed-off-by: Uli Schlachter <[email protected]>
Signed-off-by: Uli Schlachter <[email protected]>
Signed-off-by: Uli Schlachter <[email protected]>
Signed-off-by: Uli Schlachter <[email protected]>
RandR has its own Connection type, so the import had to be renamed. :-( Signed-off-by: Uli Schlachter <[email protected]>
Signed-off-by: Uli Schlachter <[email protected]>
psychon
force-pushed
the
generate-wrappers
branch
from
e9f20c1 to
8f02c95
Compare
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
--> generator/src/generator/namespace/resource_wrapper.rs:98:9
|
98 | for create_request in info.create_requests.iter() {
| ^ --------------------------- help: try: `info.create_requests.iter().flatten()`
| _________|
| |
99 | | if let Some(request) = create_request {
100 | | generate_creator(
101 | | generator,
... |
108 | | }
109 | | }
| |_________^
|
= note: `-D clippy::manual-flatten` implied by `-D warnings`
help: ...and remove the `if let` statement in the for loop
--> generator/src/generator/namespace/resource_wrapper.rs:99:13
|
99 | / if let Some(request) = create_request {
100 | | generate_creator(
101 | | generator,
102 | | out,
... |
107 | | );
108 | | }
| |_____________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
error: aborting due to previous error
Signed-off-by: Uli Schlachter <[email protected]>
eduardosm
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the XID wrappers are mostly hand-written. The macro helps a lot, but this is still too much.
This PR moves them into the code generator. The code generator has all necessary information to also generate the "create" function (like
create_window). This makes adding new types a lot easier.Future work:
Somewhere on my todo list is to extend this to also cover all the extensions. However, that's a bit tedious, because the XML does not provide this information (see #589). I already went through the extensions and marked stuff as "this looks like it creates an object that should be freed", but since I do not know most extensions, I want to double check against the various specs that I got this right.