Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI workflow by removing an unnecessary dependency for the matrix setup and adding a new job to explicitly check the results of key jobs due to GitHub Actions limitations.
- Removed
needs: unittestsfrom thesetmatrixjob so the matrix is always generated. - Added a
check-workflow-statusjob to fail the workflow ifunittestsorbuilddockerjobs fail or are cancelled. - Included a TODO comment linking to GitHub’s discussion on selecting multiple dependencies.
Comments suppressed due to low confidence (3)
.github/workflows/TestPullRequest.yml:133
- The first argument "check-labels" does not match any defined job. It should reference the actual job name (e.g., "unittests") to correctly report its status.
exit_on_result "check-labels" "${{ needs.unittests.result }}"
.github/workflows/TestPullRequest.yml:134
- The label "run-tests" here doesn't correspond to any job in
needs. Consider using "builddocker" or updating the job reference to match.
exit_on_result "run-tests" "${{ needs.builddocker.result }}"
.github/workflows/TestPullRequest.yml:119
- [nitpick] The inline array syntax with trailing commas is inconsistent with the rest of the workflow. Consider using the standard block list (`- unittests
- builddocker`) for readability and consistency.
[
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.