Skip to content

Develop #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 29, 2025
Merged

Develop #220

merged 6 commits into from
Jun 29, 2025

Conversation

ptr727
Copy link
Owner

@ptr727 ptr727 commented Jun 28, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 28, 2025 18:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflow by removing an unnecessary dependency for the matrix setup and adding a new job to explicitly check the results of key jobs due to GitHub Actions limitations.

  • Removed needs: unittests from the setmatrix job so the matrix is always generated.
  • Added a check-workflow-status job to fail the workflow if unittests or builddocker jobs fail or are cancelled.
  • Included a TODO comment linking to GitHub’s discussion on selecting multiple dependencies.
Comments suppressed due to low confidence (3)

.github/workflows/TestPullRequest.yml:133

  • The first argument "check-labels" does not match any defined job. It should reference the actual job name (e.g., "unittests") to correctly report its status.
          exit_on_result "check-labels" "${{ needs.unittests.result }}"

.github/workflows/TestPullRequest.yml:134

  • The label "run-tests" here doesn't correspond to any job in needs. Consider using "builddocker" or updating the job reference to match.
          exit_on_result "run-tests" "${{ needs.builddocker.result }}"

.github/workflows/TestPullRequest.yml:119

  • [nitpick] The inline array syntax with trailing commas is inconsistent with the rest of the workflow. Consider using the standard block list (`- unittests
  • builddocker`) for readability and consistency.
      [

@ptr727 ptr727 merged commit 7e63030 into main Jun 29, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant