Skip to content

Develop #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Develop #221

merged 3 commits into from
Jun 30, 2025

Conversation

ptr727
Copy link
Owner

@ptr727 ptr727 commented Jun 29, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 29, 2025 19:48
Copilot

This comment was marked as outdated.

@ptr727 ptr727 requested a review from Copilot June 30, 2025 00:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR strengthens command-line option handling by replacing optional value retrieval with required retrieval across all handlers, ensuring missing options trigger errors immediately.

  • Swapped GetValue calls for GetRequiredValue in version, matrix, schema, and make commands
  • No changes to option definitions—handlers now expect options to be present
Comments suppressed due to low confidence (1)

CreateMatrix/Program.cs:84

  • Using GetRequiredValue without marking the options as required can lead to unhandled exceptions at runtime. Ensure that all options (versionOption, matrixOption, updateOption, schemaVersionOption, schemaMatrixOption, makeOption, dockerOption, labelOption) are configured as required (e.g., option.IsRequired = true) or add explicit validation.
            return VersionHandler(parseResult.GetRequiredValue(versionOption));

@ptr727 ptr727 merged commit 6902acb into main Jun 30, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant