Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete bower.json #152

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Delete bower.json #152

wants to merge 5 commits into from

Conversation

aditi5050
Copy link

Issue Remove bower #35

@welcome
Copy link

welcome bot commented Jan 18, 2023

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@aditi5050 aditi5050 mentioned this pull request Jan 18, 2023
@jywarren
Copy link
Member

Thank you, this looks great!

@govindgoel
Copy link
Member

@aditi5050 Tests seems to be failing

@jywarren
Copy link
Member

Yes, i had gotten:

npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t git://github.com/jywarren/woofmark.git
npm ERR! fatal: unable to connect to github.com:
npm ERR! github.com[0: 140.82.112.4]: errno=Connection timed out
npm ERR! exited with error code: 128

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-01-2[7](https://github.com/publiclab/inline-markdown-editor/actions/runs/4028166402/jobs/6924750764#step:5:8)T21_11_49_[8](https://github.com/publiclab/inline-markdown-editor/actions/runs/4028166402/jobs/6924750764#step:5:9)48Z-debug.log
Error: Process completed with exit code 1.

I believe this is because the woofmark library is defined in the git:// protocol and will try to fix it.

@jywarren
Copy link
Member

I will bump the PublicLab.Editor library to 3.1.1, and I believe that will work.

@jywarren
Copy link
Member

Hmm, ok, was able to get past the git:// error but we are now seeing all tests pass and yet they get stuck in some kind of recursive loop running over and over: https://github.com/publiclab/inline-markdown-editor/actions/runs/4149410625/jobs/7178357164#step:7:475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants