Skip to content

Conversation

@robin-natale
Copy link
Contributor

@robin-natale robin-natale commented Feb 18, 2020

Fixes #391 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Copy link
Contributor

@crisner crisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your master branch seems to be polluted with the changes from the previous PR's changes and that has been carried over to your new branch. I suggest removing the master from your forked copy and pull it again from the main Public lab LEL repo. Or you could delete your fork altogether and make a new fork so that your master is clean.

@crisner
Copy link
Contributor

crisner commented Mar 2, 2020

@robin-natale, are you working on this?

@robin-natale
Copy link
Contributor Author

Hey @crisner yes! I had some trouble to set up properly the git repository on my new laptop. Later on I will push again my changes and hopefully they will be fine this time. I will send a reply as soon this is done 😉 thanks for checking in with me!!

@crisner
Copy link
Contributor

crisner commented Mar 2, 2020

Awesome! 😄

@robin-natale
Copy link
Contributor Author

hey @crisner could you check if my changes got through properly? 👍

@crisner
Copy link
Contributor

crisner commented Mar 4, 2020

@robin-natale, sorry about this but could you close this PR and open a new one? It also looks like your branch has been removed.

@crisner
Copy link
Contributor

crisner commented Mar 5, 2020

I am closing this as you have an open PR for the same issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get data using bbox and populate popup data for opensense layer

2 participants