-
Notifications
You must be signed in to change notification settings - Fork 78
Leaflet environmental layers #391 #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaflet environmental layers #391 #406
Conversation
crisner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your master branch seems to be polluted with the changes from the previous PR's changes and that has been carried over to your new branch. I suggest removing the master from your forked copy and pull it again from the main Public lab LEL repo. Or you could delete your fork altogether and make a new fork so that your master is clean.
|
@robin-natale, are you working on this? |
|
Hey @crisner yes! I had some trouble to set up properly the git repository on my new laptop. Later on I will push again my changes and hopefully they will be fine this time. I will send a reply as soon this is done 😉 thanks for checking in with me!! |
|
Awesome! 😄 |
|
hey @crisner could you check if my changes got through properly? 👍 |
|
@robin-natale, sorry about this but could you close this PR and open a new one? It also looks like your branch has been removed. |
|
I am closing this as you have an open PR for the same issue. Thanks! |
Fixes #391 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!