Skip to content

Added functionality for downloading spectrum image #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jywarren merged 8 commits into from
Sep 21, 2021
Merged

Added functionality for downloading spectrum image #245

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4fedbce
Added function for downloading spectrum img
waridrox Aug 6, 2021
4368655
Adding dropdown for camera switching
waridrox Aug 21, 2021
2bd1101
Merge branch 'main' into downloadSpectrum
waridrox Aug 21, 2021
7650ccf
download file and check length
jywarren Sep 21, 2021
692c7b2
Update spectral-workbench-demo.spec.js
jywarren Sep 21, 2021
24d7062
Update spectral-workbench-demo.spec.js
jywarren Sep 21, 2021
1962fa2
Update spectral-workbench-demo.spec.js
jywarren Sep 21, 2021
d7834a7
increase file length test for downloaded image
jywarren Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions examples/capture/capture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,27 @@ $W = {
this_.getRecentCalibrations("#calibration_id");
},

downloadSpectrum: function() {
Copy link
Member

@jywarren jywarren Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome. Is this something we ought to write a test for? It seems like it could be a pretty easy test?

Copy link
Member Author

@waridrox waridrox Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, in which file would it make more sense tho 😅

Copy link
Member

@jywarren jywarren Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the test assertion would be to confirm what a.href equals.

Copy link
Member

@jywarren jywarren Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/waridrox/spectral-workbench.js/blob/downloadSpectrum/cypress/integration/spectral-workbench-demo.spec.js

Copy link
Member

@jywarren jywarren Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we try using Cypress to press the download button and then assert if a.href is not empty? If that doesn't work, then we can try inserting an image to the

function getFormattedTime() {
let current_date = new Date();
let year = current_date.getFullYear();
let month = current_date.getMonth() + 1;
let day = current_date.getDate();
let hours = current_date.getHours();
let minutes = current_date.getMinutes();
let seconds = current_date.getSeconds();
return (year + '-' + month + '-' + day + '-' + hours + '-' + minutes + '-' + seconds);
}

let base64_imgdata = $('#dataurl').val($W.canvas.toDataURL())[0].defaultValue;
console.log(base64_imgdata);

let a = document.createElement('a');
a.href = base64_imgdata;
a.download = ('spectrum_img-' + getFormattedTime() + '.png');
a.click();
},

getRecentCalibrations: function(selector) {
$.ajax({
url: "/capture/recent_calibrations.json?calibration_id=" + $W.calibration_id,
Expand Down