Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline styles assigned in ERB templates #128

Merged
merged 8 commits into from
Nov 12, 2023
Merged

Conversation

mvz
Copy link
Member

@mvz mvz commented Nov 12, 2023

Part of #126.

  • Hide spinner initially with a class
  • Remove superfluous break
  • Hide optional comment form fields with JavaScript
  • Apply tag cloud styling using a class
  • Ensure panel heading height using a class
  • Fix admin flash position without inline styling
  • Initially hide comment feedback elements using a class
  • Group tags into buckets with statically assigned sizes

This changes removes inline styles, and makes the comment form show the
optional fields when JavaScript is disabled. This is a good thing since
otherwise these fields could never be filled in that case.
The original break was present to ensure the heading was high enough to
contain the floating search form. Using the clearfix class achieves the
same effect.
@mvz mvz merged commit 63e05f4 into master Nov 12, 2023
5 checks passed
@mvz mvz deleted the remove-inline-styles branch November 12, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant