Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop requirement from ~> 1.57.1 to ~> 1.59.0 #130

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Update rubocop requirement from ~> 1.57.1 to ~> 1.59.0 #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1debfd
Update rubocop requirement from ~> 1.57.1 to ~> 1.59.0
dependabot[bot] Dec 12, 2023
384ff03
Autocorrect Style/RedundantParentheses
mvz Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/controllers/admin/articles_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ def autosave
if @article.save
flash[:success] = I18n.t("admin.articles.autosave.success")
@must_update_calendar =
(params[:article][:published_at] and
params[:article][:published_at].to_time.to_i < Time.zone.now.to_time.to_i and
@article.parent_id.nil?)
params[:article][:published_at] and
params[:article][:published_at].to_time.to_i < Time.zone.now.to_time.to_i and
@article.parent_id.nil?
respond_to do |format|
format.js
end
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/comments_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def preview

def recaptcha_ok_for?(comment)
use_recaptcha = comment.blog.use_recaptcha
((use_recaptcha && verify_recaptcha(model: comment)) || !use_recaptcha)
(use_recaptcha && verify_recaptcha(model: comment)) || !use_recaptcha
end

def new_comment_defaults
Expand Down
2 changes: 1 addition & 1 deletion app/helpers/base_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def show_meta_keyword
end

def stop_index_robots?(blog)
stop = (params[:year].present? || params[:page].present?)
stop = params[:year].present? || params[:page].present?
stop = blog.unindex_tags if controller_name == "tags"
stop = blog.unindex_categories if controller_name == "categories"
stop
Expand Down
2 changes: 1 addition & 1 deletion publify_core.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Gem::Specification.new do |s|
s.add_development_dependency "pry", "~> 0.14.2"
s.add_development_dependency "rails-controller-testing", "~> 1.0.1"
s.add_development_dependency "rspec-rails", "~> 6.0"
s.add_development_dependency "rubocop", "~> 1.57.1"
s.add_development_dependency "rubocop", "~> 1.59.0"
s.add_development_dependency "rubocop-capybara", "~> 2.19.0"
s.add_development_dependency "rubocop-factory_bot", "~> 2.24.0"
s.add_development_dependency "rubocop-performance", "~> 1.19.0"
Expand Down