Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ServerItemPaginationComponent #4480

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Use ServerItemPaginationComponent #4480

merged 1 commit into from
Oct 29, 2024

Conversation

maxkadel
Copy link
Contributor

Closes #4187

@coveralls
Copy link

coveralls commented Oct 29, 2024 •
edited
Loading

Coverage Status

coverage: 96.834% (-0.03%) from 96.867%
when pulling 0f508f1 on i4187_previous_next_to_view_component
into 97e4a21 on main.

@maxkadel maxkadel force-pushed the i4187_previous_next_to_view_component branch from 29156d0 to 0f508f1 Compare October 29, 2024 19:01
sandbergja
sandbergja approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maxkadel ! 🦄

@sandbergja sandbergja merged commit 7012c04 into main Oct 29, 2024
14 checks passed
@sandbergja sandbergja deleted the i4187_previous_next_to_view_component branch October 29, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandbergja sandbergja sandbergja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate our customized _previous_next_doc.html.erb to a view component
3 participants
@maxkadel @coveralls @sandbergja