Remove dependency on "request" package #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only used in the download-node script - now that also uses superagent instead.
confused-Techie
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
The diff here looks to have identical meaning. And I've tested to ensure NodeJS is still being installed successfully, and contains the same amount of data between installs.
Great work on this final user of request, I'll be happy to see us finally get rid of it!
DeeDeeG
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Looks good to me as well. 👍
CI is passing, with a successful rebuild of ppm's own dependencies against the downloaded Node, so the download script must be working fine. Works for me locally as well.
With two Approves, I don't see why not to merge, so I'll go ahead and merge this.
Thanks again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only used in the download-node script - now that also uses superagent instead.
I tested the download locally and it did succeed.