CI: Simplify run-tests.js and use it in editor tests workflow #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully avoids an odd test failure we see in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Basically a partial revert of 58cdd5f to try and fix a spec that is timing out in CI.
Context / Details
Hopefully avoids an odd test failure we see in CI.
This issue started to show itself after #917 was merged, despite not being an issue in that PR itself. I confirmed that specifically this commit can be reverted to make the issue go away on
masterbranch: 58cdd5fI'm in support of that commit's purpose, but we get exactly one timed out spec in CI now with that change.
Not sure what's up with that. Going to see if I can simplify
run-tests.jswithout all the "retrying failed specs" stuff. Maybe then we can get CI passing without the false positives seen with the reruns.Verification Process
Once again this is one of those CI pull requests where I open the PR itself to run CI and see if it fixes things or not. Will follow-up based on what the first run does.