Skip to content

fix: 認証を強制したエンドポイントでトークンが指定されていない場合にOption.none()を返すように #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

laminne
Copy link
Member

@laminne laminne commented May 21, 2025

close #1062

What does this PR do?

Additional information

@laminne laminne requested a review from MikuroXina May 21, 2025 12:50
@laminne laminne self-assigned this May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.26%. Comparing base (67c5f20) to head (bc9c34e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/adaptors/authenticateMiddleware.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
- Coverage   35.27%   35.26%   -0.01%     
==========================================
  Files         134      134              
  Lines       14240    14242       +2     
  Branches     1047     1047              
==========================================
  Hits         5023     5023              
- Misses       9217     9219       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laminne laminne merged commit 75abdb7 into main May 21, 2025
5 of 6 checks passed
@laminne laminne deleted the fix/1062-auth-middleware-behavior branch May 21, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(adaptors): forceAuthorizedfalse だとコンテキスト変数 accountIDaccountName が未初期化になる
2 participants